Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-zero exit code if commit is behind #2189

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

vpipkt
Copy link
Contributor

@vpipkt vpipkt commented Apr 11, 2022

What Changed

When running auto within our CI pipelines, merges in quick succession can result in the state that the commit to be released is behind the HEAD.

The current behaviour is to "silently" fail with logging a warning and exit code 0 from auto shipit. The proposed behaviour is a nonzero exit code in these cases where nothing is released.

Why

In these cases on our CI the skipped release amounts to a failure that we need to capture and reflect as a failed CI run. When the run of auto shipit is considered a success, subsequent runs of our CI & CD workflows get out of sync with repository state if the release didn't really happen.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@intuit-svc intuit-svc added the minor Increment the minor version when merged label Apr 11, 2022
@laughedelic
Copy link
Contributor

This fix has been here for a while. @hipstersmoothie could you take a look?

@hipstersmoothie
Copy link
Collaborator

Sorry for my absence. Will be looking soon! Gotta get ci working first

@hipstersmoothie hipstersmoothie merged commit 034209c into intuit:main Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🚀 PR was released in v10.39.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants