Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry doesn't seem to work always #30

Open
JeremyCroff opened this issue Jun 25, 2018 · 1 comment
Open

Retry doesn't seem to work always #30

JeremyCroff opened this issue Jun 25, 2018 · 1 comment

Comments

@JeremyCroff
Copy link
Contributor

JeremyCroff commented Jun 25, 2018

(node:49878) UnhandledPromiseRejectionWarning: Error: Request failed with status code 500
    at createError (/Users/jcroff/dev/saloon/node_modules/axios/lib/core/createError.js:16:15)
    at settle (/Users/jcroff/dev/saloon/node_modules/axios/lib/core/settle.js:18:12)
    at IncomingMessage.handleStreamEnd (/Users/jcroff/dev/saloon/node_modules/axios/lib/adapters/http.js:201:11)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
(node:49878) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:49878) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.```
@JeremyCroff
Copy link
Contributor Author

thoughts:

  1. the user implementing the seeder could add a catch block on its invocation
  2. or we could internally handle failed promise with a catch block on the seed level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant