Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider caching isbn definitions on load #5

Open
mvolz opened this issue Dec 6, 2019 · 6 comments
Open

Consider caching isbn definitions on load #5

mvolz opened this issue Dec 6, 2019 · 6 comments

Comments

@mvolz
Copy link

mvolz commented Dec 6, 2019

The ISBN definitions seem to be updated fairly frequently as far as I can tell. Would it be possible to make a request on loading the library for the new definitions? The hard-coded ones could be used as back-up if the library is offline / the website is down. If that seems like something that we want to do I could make a PR.

@maxlath
Copy link
Member

maxlath commented Dec 6, 2019

maybe as a postinstall script or something of this kind?

@mvolz
Copy link
Author

mvolz commented Dec 10, 2019

I was thinking more of making the request as part of an init sort of thing. So the request is made once, when the application is started.

@maxlath
Copy link
Member

maxlath commented Dec 10, 2019

I wouldn't like it to be the default behaviour as that would:

  • make the startup much slower
  • add a dependency on isbn-international.org status
  • add a non-dev dependency on a xml parsing lib

I tried to improve the documentation on how one could update the groups without having to rely on those being updated by the module maintainers, could that be enough?

Edit: I reverted the change in the documentation as that's actually bad advice: as re-running npm install in the root project will revert the group update

@maxlath
Copy link
Member

maxlath commented Aug 1, 2020

I added a CI action to auto-update groups data every 1st of the month: today was the first auto-update+patch version publication triggered that way.

This means that as long as this action is up and there is no breaking change in the isbn-international.org API, we [the maintainers] could well totally forget about this repo and it would still be periodically updated.

@natlibfi-jonollil
Copy link

There has been change Dec 18, 2020. Is auto update working? (Top margin in pdf says so https://www.isbn-international.org/range_file_generation)

@maxlath
Copy link
Member

maxlath commented Jan 11, 2021

The action was disabled for some reason I don't get, but now it's reactivated, and I manually ran (8afee59) and published (v1.1.7) an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants