Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): set all services / activities to exported=false #1132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): set all services / activities to exported=false #1132

wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Contributor

All of our services and receivers either receive system broadcasts or Intents / PendingIntents from ourselves (internal use, in other words) so they do not need to be exported

@mikehardy
fix(android): set all services / activities to exported=false
a1e6ae5 
All of our services and receivers either receive system
broadcasts or Intents / PendingIntents from ourselves
(internal use, in other words) so they do not need to be exported
@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Oct 26, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (4ffc748) to head (a1e6ae5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1132   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files          32       32           
  Lines        1727     1727           
  Branches      578      579    +1     
=======================================
  Hits         1331     1331           
  Misses        343      343           
  Partials       53       53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henrryxdjr Henrryxdjr Henrryxdjr approved these changes

Assignees
No one assigned
Labels
pending-merge Waiting on CI or question responses to merge, but otherwise ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting exported to false in Notifee Core
2 participants
@mikehardy @Henrryxdjr