Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rewarded interstitial, ios): fixed false error with valid event type value #148

Merged
merged 2 commits into from
May 12, 2022
Merged

fix(rewarded interstitial, ios): fixed false error with valid event type value #148

merged 2 commits into from
May 12, 2022

Conversation

parasdaryanani
Copy link
Contributor

Description

Rewarded interstitial ads seem to throw an error when creating an event listener, even though the event type is valid.

Related issues

Fixes #147

Release Summary

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

The expected event type is rewarded_interstitial, although error checking

Before:
Screenshot 2022-05-12 at 16 08 11

After:
Screenshot 2022-05-12 at 16 07 51


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@CLAassistant
Copy link

CLAassistant commented May 12, 2022

CLA assistant check
All committers have signed the CLA.

@parasdaryanani parasdaryanani marked this pull request as ready for review May 12, 2022 15:09
@parasdaryanani parasdaryanani marked this pull request as draft May 12, 2022 15:09
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #148 (c79f0b7) into main (3049ea3) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head c79f0b7 differs from pull request most recent head 9fd570a. Consider uploading reports for the commit 9fd570a to get more accurate results

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   22.73%   22.70%   -0.02%     
==========================================
  Files          34       34              
  Lines         801      802       +1     
  Branches      196      197       +1     
==========================================
  Hits          182      182              
- Misses        619      620       +1     

Copy link
Collaborator

@wjaykim wjaykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this issue! I'm surprised that we haven't tested this case. Sorry, this library is fast-growing library, so there's still some rough-edges 🙏. I'll merge this after the workflows are passed.

@wjaykim
Copy link
Collaborator

wjaykim commented May 12, 2022

@parasdaryanani I would be appreciated if you run yarn lint from the root of the project and commit the changes.

@wjaykim
Copy link
Collaborator

wjaykim commented May 12, 2022

@parasdaryanani We ask that you sign our Contributor License Agreement before we can accept your contribution.

@parasdaryanani parasdaryanani marked this pull request as ready for review May 12, 2022 15:52
@wjaykim wjaykim merged commit 7ee21bf into invertase:main May 12, 2022
@mikehardy
Copy link
Collaborator

@parasdaryanani thanks so much for the help!

github-actions bot pushed a commit that referenced this pull request May 14, 2022
### [6.2.5](v6.2.4...v6.2.5) (2022-05-14)

### Bug Fixes

* fix ad inspector callback error ([c652d5e](c652d5e))
* fix false error in rewarded interstitial with valid event type value ([#148](#148)) ([7ee21bf](7ee21bf))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 6.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
### [6.2.5](invertase/react-native-google-mobile-ads@v6.2.4...v6.2.5) (2022-05-14)

### Bug Fixes

* fix ad inspector callback error ([c652d5e](invertase/react-native-google-mobile-ads@c652d5e))
* fix false error in rewarded interstitial with valid event type value ([#148](invertase/react-native-google-mobile-ads#148)) ([7ee21bf](invertase/react-native-google-mobile-ads@7ee21bf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] (:fire:) Error: RewardedInterstitialAd.addAdEventListener(*) 'type' expected a valid event type value.
4 participants