-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ppid option to request options #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 22.70% 22.59% -0.11%
==========================================
Files 34 34
Lines 802 806 +4
Branches 197 195 -2
==========================================
Hits 182 182
- Misses 620 624 +4 |
Hey Jay! It's a holiday here, just to say if no one else gets to it, apologies for the delay, I will as soon as I work through email etc backlog tomorrow when I'm back at work. Also I didn't mean to just put a full stop to what looked like a certain performance win with the deallocation PR etc that is sitting idle. Any even minimal examination of Android Studio memory profiler would be good enough for me on that one :-). I mostly just want to make sure it actually does what it's intended since I have been surprised there before (usually because of a silly coding error that I made, you know how it goes...) Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry it took me this long to look at the PR, it all looks obviously correct to me on first read, just a clean addition of a new property ✔️
## [6.3.0](v6.2.5...v6.3.0) (2022-05-31) ### Features * add ppid option to request options ([#153](#153)) ([8bbfc05](8bbfc05))
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@mikehardy Thank you, I'm busy these days too, totally understand. |
## [6.3.0](invertase/react-native-google-mobile-ads@v6.2.5...v6.3.0) (2022-05-31) ### Features * add ppid option to request options ([#153](invertase/react-native-google-mobile-ads#153)) ([8bbfc05](invertase/react-native-google-mobile-ads@8bbfc05))
Description
This PR adds
publisherProvidedId
property to RequestOptions.Related link: https://developers.google.com/ad-manager/mobile-ads-sdk/android/targeting#publisher_provided_identifiers
Related issues
Release Summary
Added
publisherProvidedId
property to request optionsChecklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter