Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ppid option to request options #153

Merged
merged 2 commits into from
May 30, 2022
Merged

feat: add ppid option to request options #153

merged 2 commits into from
May 30, 2022

Conversation

wjaykim
Copy link
Collaborator

@wjaykim wjaykim commented May 23, 2022

Description

This PR adds publisherProvidedId property to RequestOptions.
Related link: https://developers.google.com/ad-manager/mobile-ads-sdk/android/targeting#publisher_provided_identifiers

Related issues

Release Summary

Added publisherProvidedId property to request options

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #153 (71c5771) into main (c652d5e) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head 71c5771 differs from pull request most recent head dcd57be. Consider uploading reports for the commit dcd57be to get more accurate results

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   22.70%   22.59%   -0.11%     
==========================================
  Files          34       34              
  Lines         802      806       +4     
  Branches      197      195       -2     
==========================================
  Hits          182      182              
- Misses        620      624       +4     

@mikehardy
Copy link
Collaborator

Hey Jay! It's a holiday here, just to say if no one else gets to it, apologies for the delay, I will as soon as I work through email etc backlog tomorrow when I'm back at work. Also I didn't mean to just put a full stop to what looked like a certain performance win with the deallocation PR etc that is sitting idle. Any even minimal examination of Android Studio memory profiler would be good enough for me on that one :-). I mostly just want to make sure it actually does what it's intended since I have been surprised there before (usually because of a silly coding error that I made, you know how it goes...) Cheers

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry it took me this long to look at the PR, it all looks obviously correct to me on first read, just a clean addition of a new property ✔️

@mikehardy mikehardy merged commit 8bbfc05 into main May 30, 2022
@mikehardy mikehardy deleted the @wjaykim/ppid branch May 30, 2022 23:23
github-actions bot pushed a commit that referenced this pull request May 31, 2022
## [6.3.0](v6.2.5...v6.3.0) (2022-05-31)

### Features

* add ppid option to request options ([#153](#153)) ([8bbfc05](8bbfc05))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wjaykim
Copy link
Collaborator Author

wjaykim commented May 31, 2022

@mikehardy Thank you, I'm busy these days too, totally understand.

Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants