[bug]: installed models being redownloaded

[isNeil]

Is there an existing issue for this?

• I have searched the existing issues

OS

Linux

GPU

cuda

VRAM

No response

What version did you experience this issue on?

v3.6.0

What happened?

In InvokeAI/invokeai/backend/install/model_install_backend.py
function _remove_installed is expected to remove all already installed models from the model_list of models to be downloaded however some installed models are being "missed".

This is caused by the for loop modifying it's own iterable model_list.remove() which causes the loop to skip elements in the model_list.

As a result, some existing models are redundantly being redownloaded.

    def _remove_installed(self, model_list: List[str]):
        all_models = self.all_models()
        for path in model_list:
            key = self.reverse_paths.get(path)
            if key and all_models[key].installed:
                logger.warning(f"{path} already installed. Skipping.")
                model_list.remove(path)

Screenshots

No response

Additional context

No response

Contact Details

@NeilWng