Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-and-release fails for wwwOnly adapters #577

Closed
mcm1957 opened this issue Sep 12, 2023 · 2 comments · Fixed by #594
Closed

test-and-release fails for wwwOnly adapters #577

mcm1957 opened this issue Sep 12, 2023 · 2 comments · Fixed by #594

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 12, 2023

If an adapter declares '"onlyWWW": true,' then the tests should not fail with error if no 'main' attribute exists within package.json.

Adapter checker seems to handle this correctly.

Example:
https://github.com/iobroker-community-adapters/ioBroker.icons-smarthome

  1) Validate the package files
       Check contents of package.json
         The property "main" exists:
     AssertionError: expected undefined not to be undefined
      at Context.<anonymous> (node_modules/@iobroker/testing/build/tests/packageFiles/index.js:61:57)
      at process.processImmediate (node:internal/timers:476:21)

Workarounds:

  • declare a dummy main (i.e. main:README.md)
  • manipulate test-and-release.yml

Both options are suboptimal. The satndard test environment should be able to handle this.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Oct 22, 2023

@AlCalzone
Do you have any spare time to add this exception to standard tests?
Or would this be more effort than I guess.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Feb 24, 2024

should be solved by PR #594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant