Fix for datetime support on bokeh BoxPlot #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: bug
|
I would like to hear what the Bokeh devs have to say before merging - this issue of not supporting colons is very weird! |
|
Here's the issue on it: bokeh/bokeh#516, currently marked 0.12.5. In the meantime I need this for a project, so I'd suggest we merge and I'll open an issue to follow up on, which can hopefully be merged before 1.7 is released. |
Sounds good. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokeh does not currently handle datetimes on their boxwhisker chart implementation, in the meantime this PR simply casts the datetimes to strings, replacing any colons with semi-colons because those are also not supported. I'll file an issue about it on the bokeh repo, but since the charts API may get deprecated it may not get addressed.