-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operation fixes #1093
Operation fixes #1093
Conversation
2afe29a
to
51a56b4
Compare
Ready to review. |
51a56b4
to
144b7e2
Compare
Looks good though I am worried about backwards compatibility implications for point 3. I agree with your rationale for removing the adjoin option but is anyone using it? How about checking if |
I suspect people were sufficiently discouraged from using. I'm happy to add the exception but in fixing it I realized the operation itself was fairly useless in all kinds of ways, auto-ranging was disabled for instance so without supplying an explicit |
Ok. In that case, I am happy to merge...although the pr build does seem to have failed right now... |
One of the many transients we're struggling with again, about 1/4 builds fail. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
A number of small fixes for existing operations:
Disable the
group
being inherited from composite types as would sometimes occur when applying operations to an NdOverlay resulting in Element being labeled "NdOverlay".Hide warning in
datashade
operation when shading a categorical aggregate.Removed the adjoin parameter to
histogram
operation, it continually annoys me because thehist
method has to handle the adjoining itself anyway and having the operation return an adjoined object is a) weird and b) actually breaks if you're trying to apply the operation to a HoloMap or other kind of composite object.