-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dynamic dimension values #1103
Conversation
holoviews/core/util.py
Outdated
""" | ||
Merges lists of fully or partially overlapping dimensions by | ||
combining their values. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is clear enough, but it might be nice to add a doctest example here (if we are using doctests).
Looks like my comment in the issue regarding a |
I think this uses it everywhere it matters, i.e. when merging |
Thanks for adding the doctest! Happy to merge once the tests pass. |
Some syntax error due to the test being multi-line. |
03fb900
to
f66ec43
Compare
Ready to merge when it passes. |
Tests have passed. Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Merges the values from multiple composed DynamicMaps addressing #920.