Fixed ErrorBarPlot mpl2.0 compat and made it more general #1131
Conversation
| _, (bottoms, tops), verts = ax.errorbar(*plot_data, **plot_kwargs) | ||
| handles = ax.errorbar(*plot_data, **plot_kwargs) | ||
| bottoms, tops = None, None | ||
| if mpl_version >= str('2.0'): |
There was a problem hiding this comment.
So this is the only bit that changes specifically for matplotlib 2.0+?
There was a problem hiding this comment.
No the update code also had to change because the caps aren't instantiated by default.
|
Tests appear to be failing because this display output 46 in Elements has changed. Here is what it looks like:
What that has to do with errorbars I do not know. |
|
Wow..that is a pretty strange side-effect! Definitely no error bars there! |
philippjfr
force-pushed
the
errorbars_fix
branch
from
1ed2c7a
to
53d4857
Compare
philippjfr
force-pushed
the
errorbars_fix
branch
from
53d4857
to
adfd115
Compare
|
So I'm super confused now, the test above is meant to look like this:
Why would annotations disappear after fixing a completely different plot? |
|
Figured it out, this is why |
philippjfr
force-pushed
the
errorbars_fix
branch
from
adfd115
to
0ddb490
Compare
Ha! Yes, let's not use glob imports. Anyway, now that is resolved, this PR looks fine and the tests have passed without needing to be updated. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
ErrorBars were one of the only failures in our compatibility with mpl 2.0, the difference is that errorbar caps are disabled by default and that the return signature differs. This adds that compatibility and also made the plot correctly animate ErrorBar plots with varying numbers of error bars and adds support for inverting axes on the plot allowing it to be adjoined correctly.