Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh protocol improvements #1896

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Bokeh protocol improvements #1896

merged 3 commits into from
Sep 20, 2017

Conversation

philippjfr
Copy link
Member

Three small fixes to improve event handling with bokeh protocol:

  • Place hold on Document after adding root (avoid RootAdded events)
  • Avoid sending updates without events entirely
  • Only update colormapper if attributes have changed (avoid ModelChanged events and glyph redraws)

@philippjfr
Copy link
Member Author

Ready to merge. At some point we should go through the entire bokeh backend and ensure that we don't needlessly set bokeh model attributes, the colormapper was just a very obvious case to do this since every change to it triggers a full rerender of the glyph.

@jlstevens
Copy link
Contributor

Looks good! Merging.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants