Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of JS and CSS dependencies #426

Merged
merged 11 commits into from
Feb 1, 2016
Merged

Conversation

philippjfr
Copy link
Member

This PR is an attempt at making the handling of JS and CSS dependencies a bit more sane to allow exporting of notebooks and individual widgets more easily and ensure sufficient control over which libraries are included.

@philippjfr philippjfr added this to the v1.4.2 milestone Jan 28, 2016
js_dependencies = Renderer.js_dependencies + CDN.js_files

css_dependencies = Renderer.css_dependencies + CDN.css_files
backend_dependencies = {'js': CDN.js_files, 'css': CDN.css_files}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely cleaner. I assume you'll collect the core renderer dependencies together later...

@jlstevens
Copy link
Contributor

Looks good to me as soon as you address the comments I've made.

@jlstevens
Copy link
Contributor

Thanks for the fix. Merging.

jlstevens added a commit that referenced this pull request Feb 1, 2016
Improved handling of JS and CSS dependencies
@jlstevens jlstevens merged commit 82fe5cf into master Feb 1, 2016
@jlstevens jlstevens deleted the jsdependencies branch February 4, 2016 16:07
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants