-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of JS and CSS dependencies #426
Conversation
js_dependencies = Renderer.js_dependencies + CDN.js_files | ||
|
||
css_dependencies = Renderer.css_dependencies + CDN.css_files | ||
backend_dependencies = {'js': CDN.js_files, 'css': CDN.css_files} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely cleaner. I assume you'll collect the core renderer dependencies together later...
Looks good to me as soon as you address the comments I've made. |
Thanks for the fix. Merging. |
Improved handling of JS and CSS dependencies
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR is an attempt at making the handling of JS and CSS dependencies a bit more sane to allow exporting of notebooks and individual widgets more easily and ensure sufficient control over which libraries are included.