Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer instances keep track of last plot #538

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Conversation

philippjfr
Copy link
Member

This PR adds a last_plot attribute to Renderer instances, which let's the user easily get a handle on the last thing they plotted, which is very helpful for debugging, understanding how plots are structured, and in order to directly customize a plot, e.g. to prototype an initial_hook or final_hook.

@jlstevens
Copy link
Contributor

As we've discussed, Renderer is the right place to put this and it is a small change. I would be happy to merge but I'm wondering what is up with Travis right now...

@philippjfr
Copy link
Member Author

Restarted the tests, ready to merge when it goes green.

@jlstevens
Copy link
Contributor

Tests are passing. Merging.

jlstevens added a commit that referenced this pull request Mar 11, 2016
Renderer instances keep track of last plot
@jlstevens jlstevens merged commit 3d19cfc into master Mar 11, 2016
@philippjfr philippjfr deleted the renderer_last_plot branch April 1, 2016 14:27
@philippjfr philippjfr added this to the v1.5.0 milestone Apr 20, 2016
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants