Removed caching of Table values #850
Conversation
|
One consequence of using streams is that it isn't possible for |
| @@ -117,7 +115,7 @@ def initialize_plot(self, ranges=None): | |||
| for col in range(element.cols): | |||
| if summarize and row > half_rows: | |||
| adjusted_row = (element.rows - self.max_rows + row) | |||
| cell_value = self.cell_values[self.keys[-1]][(row, col)] | |||
| cell_value = element.pprint_cell(row, col) | |||
There was a problem hiding this comment.
Shouldn't both of these calls also pass the return value through the pprint_value method on TablePlot, I'm not sure why both the element and the plot need a pprint method but I assume there was a reason.
There was a problem hiding this comment.
Well spotted! I've just pushed a commit to fix this.
|
Looks good now. Happy to merge when tests pass. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR allows Tables to be updated with streams by disabling the caching of cell values in TablePlot. I've tested that streams now work but I won't be confident that everything is working as it should until the tests pass.