-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error reporting on comms #906
Conversation
17d69ab
to
63c1460
Compare
I'm very happy with this, especially as everything stays simple on the Javascript side. My only comments:
with StandardOutput() as stdout:
...
if stdout: ... You'll need two context managers if you want to also handle stderr - at least if you want to continue using each one inheriting from with StandardOutput() as stdout, StandardError() as stderr:
...
if stdout: ...
if stderr: ... The redundancy between the |
b7ac1b1
to
e2c55ec
Compare
Great, tests are passing! Merging. |
I know this PR is merged now but I want to just state one thing that is still niggling at me. How will a regular user even know the check the Javascript console for messages? Both of us know that the output is going there now but it is invisible to everyone else until they look at the docs to find out. Not sure how best to handle this. Javascript alerts would be very obvious, but also very annoying...though maybe for stdout, using alerts might make sense even if exceptions don't? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Improves the traceback reported in the console on error by including filename, error type, line number and function.