-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bokeh adjoined histogram adds support for live colormapping #928
Conversation
Cool! The code looks clean to me, but maybe better if @jlstevens merges it just to be sure. |
Based off #927, so that should be merged first. |
#927 is merged, so can this be merged now? |
Yes, I just have to rebuild test data first (because you broke it 😄). |
Is the test data in github? Seems easier just to edit that one character. |
PR #927 has now been merged and this functionality is certainly very nice (especially as it doesn't need a live server). My only concern is that it doesn't seem hugely intuitive to me to use the box select tool on a side histogram. Other than that, I am happy to merge. |
The box select tool seems very intuitive to me, in terms of mouse clicking; it's just that ideally the visual representation of the selection would not be a box but a range of histogram bins. I.e., the same clicks should do the same thing, but the selected area should show bins, not portions of bins, ideally. Still, that seems like a nicety that could be added someday, and shouldn't hold up this PR. |
It is certainly nice functionality! Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
An adjoined histogram in bokeh now automatically shares the color mapper of whatever plot it is adjoined to it and adds a
box_select
tool with aCustomJS
to update that colormapper based on the current selection. Since this callback is pure JS this will also work on static export.