Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website update #936

Merged
merged 11 commits into from
Oct 28, 2016
Merged

Website update #936

merged 11 commits into from
Oct 28, 2016

Conversation

philippjfr
Copy link
Member

No description provided.

@jlstevens
Copy link
Contributor

Ah, I said I would add a bit of text describing mybinder and holoviews-contrib. Don't merge till I've done that!

@philippjfr
Copy link
Member Author

@jlstevens Any update on this?

@jlstevens
Copy link
Contributor

@philippjfr I'll take a look at it now.

@jlstevens
Copy link
Contributor

Sorry I didn't get to this earlier! My first change is this:

image

I'm not sure this is the best approach but I think a link to the dev part of the website would be useful.

@jlstevens
Copy link
Contributor

My next change is to try and shorten the first paragraph in the Homepage notebook while also linking to holoviews-contrib. I think we agree that the original homepage had a bit too much text before presenting the first visualization. I also think the following paragraph covers the key points.

As this is an edit to the first thing people see on the homepage, we should all make sure we are happy with it before making it live!

@jlstevens
Copy link
Contributor

I've also linked to holoviews-contrib from the tutorials index. I think this conclude the most urgent changes I wanted to make to the website at this time.

We should review all these changes carefully and if we are happy, we can then merge and update the website.

@@ -9,7 +9,7 @@ you may also try out live copies on `mybinder.org
explore many other examples in our `contrib repository
<https://github.com/ioam/holoviews-contrib>`_. Lastly, for the most
responsive experience, you can install HoloViews and try out the
`tutorial notebooks`_ for yourself.
tutorial notebooks for yourself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this was meant to link to, but it wasn't linking to anything anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a broken link - it gets replaced with the right link based on the current version in setup.py. See the replacement here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Way too tricky! In that case, why is it linking to the bogus 1.5.0 version then on the live site, since setup.py was surely declaring 1.6.2?

Copy link
Contributor

@jlstevens jlstevens Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works just fine which is why the dev version is correctly pointing to 1.6.2 - the issue is that we need to copy the files from the dev version over to the main website on release. I think what happened is that the website building infrastructure broke at some point so that the files must have been stale.

What I do know is that there are tricky bits to updating the docs/website but thankfully this isn't one of them! :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way to do website fixes for a particular release, rather than for the current master? I.e. if we wanted to update the website now, then it would be updated with the git version of holoviews, not the latest release. Are we only able to update it just after a release?

@philippjfr
Copy link
Member Author

Thanks for the updates. Merging and updating the website.

@philippjfr philippjfr merged commit 83b82a9 into master Oct 28, 2016
@philippjfr philippjfr deleted the website_update branch January 7, 2017 15:01
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants