Skip to content

Commit

Permalink
build: turn on debug-safe optimizations with -Og
Browse files Browse the repository at this point in the history
The resulting binary is still easy to inspect in gdb but is not as dog
slow.  The 'parallel' test suite, although it takes several minutes to
complete, now finishes without any tests timing out.

PR-URL: #1569
Reviewed-By: Johan Bergström <[email protected]>
  • Loading branch information
bnoordhuis committed May 1, 2015
1 parent 0450ce7 commit 78f4b03
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
'node_tag%': '',
'uv_library%': 'static_library',

# Default to -O0 for debug builds.
# Default to -Og for debug builds.
'v8_optimized_debug%': 0,

# Enable disassembler for `--print-code` v8 options
Expand Down Expand Up @@ -54,7 +54,7 @@
'v8_enable_handle_zapping%': 1,
},
'defines': [ 'DEBUG', '_DEBUG' ],
'cflags': [ '-g', '-O0' ],
'cflags': [ '-g', '-Og' ],
'conditions': [
['target_arch=="x64"', {
'msvs_configuration_platform': 'x64',
Expand Down

0 comments on commit 78f4b03

Please sign in to comment.