Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -J from test-ci and fix test-net-dns-custom-lookup #1544

Merged
merged 1 commit into from
Apr 28, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 28, 2015

This pulls in #1531 as well because it's the way to get passing builds on Jenkins when combined with removing -J from the test runner.

Ideally we should be able to use -J but it's borked on most of the build slaves but it would be nice if we could have it working so they are quicker to run. Something for @indutny to chime in on perhaps, @jbergstroem has also been looking at it.

Test run for these 2 commits: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/630/

@jbergstroem
Copy link
Member

The rationale behind still using -J is that its faster (by running tests in parallel). If tests starts failing because of either higher load on the host or that the runner/jenkins or something else in the environment makes it fail that's something we need to fix. I'm afraid of ending up in a situation where we prefer sweeping things under the rug because we're gunning for test pass, no matter how we get there.

Anyway, -J was introduced with moving to make test-ci which is only a few days old. I'm happy to go back to our known state to ensure that 2.0 gets out but want to further investigate whats going on with our tests once run in parallel.

LGTM.

@rvagg
Copy link
Member Author

rvagg commented Apr 28, 2015

yes, for the record, we haven't actually been using -J on CI until now but we should get there

parallel tests still not working on most build slaves

PR-URL: nodejs#1544
Reviewed-By: Johan Bergström <[email protected]>
@rvagg rvagg merged commit 2a3c8c1 into nodejs:master Apr 28, 2015
@rvagg
Copy link
Member Author

rvagg commented Apr 28, 2015

merged as 2a3c8c1, #1531 went in separately

@rvagg rvagg deleted the no-minus-jay branch April 28, 2015 06:12
@rvagg rvagg mentioned this pull request Apr 28, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 29, 2015
parallel tests still not working on most build slaves

PR-URL: nodejs#1544
Reviewed-By: Johan Bergström <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 14, 2015
parallel tests still not working on most build slaves

PR-URL: nodejs#1544
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / 2a3c8c1
Reviewed-By: Johan Bergström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants