doc: improve http.request and https.request options #1551
Conversation
|
If we want to explicitly support the |
|
Also copied all options from |
silverwind
changed the title
| preferred over `host`. | ||
| - `family`: IP address family to use when resolving `host` and `hostname`. | ||
| Valid values are `4` or `6`. When unspecified, both IP v4 and v6 will be | ||
| used. |
There was a problem hiding this comment.
@cjihrig didn't your example in the original issue state that this was required for ipv6?
There was a problem hiding this comment.
@Fishrock123 TL;DR, I believe @silverwind statement to be correct here.
In that particular example, IPv6 was required, as the server was only listening on '::1'. When dns.lookup() executes, it looks up localhost and returns the results [ '127.0.0.1', '::1', 'fe80::1' ] (on my local machine). The first result is used, and the family is inferred as 4.
There was a problem hiding this comment.
I understood #708 as a request to attempt multiple IPs from the same family.
What exactly does a browser on dual stack do if it encounters both v4 and v6? Attempt both in succession? In parallel? Whatever it does, I think that's what we should do if no family is given.
silverwind
changed the title
|
@Fishrock123 Any objections to me merging this right now? I think it's a clear improvement. |
|
LGTM |
This adds a few previously undocumented option to both functions. PR-URL: #1551 Fixes: #1082 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in b4ad5d7 |
Fixes #1082. Also made the
hostnameoption more clear.R=@cjihrig