url: significantly improve the performance of the url module #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2015
petkaantonov
added
the
semver-major
|
@petkaantonov Is this ready to land in your mind? |
|
@piscisaureus yes although @domenic might want to check it out |
|
LGTM! |
|
Very happy about getting the WhatWG tests in. Great job both @petkaantonov and all diligent reviewers. |
|
Original PR for posterity: #933 |
|
What is this waiting on before it can be merged? Nothing, right? |
petkaantonov
added a commit
that referenced
this pull request
May 2, 2015
(landed by @rvagg) PR-URL: #1561 Reviewed-By: Domenic Denicola <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
took the liberty of landing this, I hope you don't mind @petkaantonov. 3fd7fc4 |
This was referenced May 2, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to target master