Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong/incomplete JS-Doc in Camera-Plugin #2195

Open
flgubler-ergon opened this issue Sep 18, 2024 · 1 comment
Open

Wrong/incomplete JS-Doc in Camera-Plugin #2195

flgubler-ergon opened this issue Sep 18, 2024 · 1 comment
Labels

Comments

@flgubler-ergon
Copy link

Bug Report

Plugin(s)

Camera plugin

Capacitor Version

  @capacitor/cli: 6.1.0
  @capacitor/core: 6.1.0
  @capacitor/android: 6.1.0
  @capacitor/ios: 6.1.0

Platform(s)

Web (iOS)

Current Behavior

The property presentationStyle has the following JS-doc

    /**
     * iOS only: The presentation style of the Camera.
     * @default: 'fullscreen'
     *
     * @since 1.0.0
     */
    presentationStyle?: 'fullscreen' | 'popover';

It sais that the property only influences the style of the camera. But in reality, it also influences the style of the photo-picker in the same way.

Expected Behavior

The JS-doc should specify that the photo-picker also influenced by the property.

Code Reproduction

I guess this does not really make sense, here, but I am talking about this file: https://github.com/ionic-team/capacitor-plugins/blob/main/camera/src/definitions.ts

Copy link

ionitron-bot bot commented Oct 16, 2024

This issue has been labeled as type: bug. This label is added to issues that that have been reproduced and are being tracked in our internal issue tracker.

@alexgerardojacinto alexgerardojacinto removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants