Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Splash Screen API #561

Closed
jcesarmobile opened this issue Aug 23, 2021 · 6 comments · Fixed by #1011
Closed

Migrate to Splash Screen API #561

jcesarmobile opened this issue Aug 23, 2021 · 6 comments · Fixed by #1011

Comments

@jcesarmobile
Copy link
Member

Feature Request

Plugin

splash-screen

Description

When targeting Android SDK 31, a new Splash Screen API can be used

https://developer.android.com/about/versions/12/splash-screen-migration?hl=es

Some features might not be possible with that API.

Platform(s)

android

Preferred Solution

Alternatives

Additional Context

@mcfarljw
Copy link

I just got a new device with Android 12 (Samsung Galaxy S22) and thought I was going crazy when seeing two splash screens. Does anybody know of any quick and relatively painless ways of disabling the Ionic Capacitor splash screen for SDK 31+ devices while this plugin gets updated?

@jcesarmobile jcesarmobile added the type: feature request A new feature, enhancement, or improvement label Feb 24, 2022
@maxcodefaster
Copy link

This seems to be becoming more and more important as Android 12 is adopted more and more every day.

@maxcodefaster
Copy link

There seems to be a workaround, at least for the cordova plugin: apache/cordova-plugin-splashscreen#311 (comment)

@mster81
Copy link

mster81 commented Mar 28, 2022

Full disclosure, I don't know if this is the correct solution here but doing some testing and adding this to the 'styles.xml'

<style name="AppTheme.NoActionBarLaunch" parent="AppTheme.NoActionBar">
      <item name="android:background">@drawable/splash</item>
      <item name="android:windowIsTranslucent">false</item>
      <item name="android:colorBackground">#ff0000</item>
 </style>

Allows me to control the first splash to a degree anyhow..

If setting windowisTranslucent to false, it will not show the first splash icon.. Next, and I don't know why but if adding the colorBackground, I can get the background to change from black to white, however it does not honor the hex value.. This is OK for me because changing light to dark is enough to add the contrast, however it would be nice to be able to change that.

I lack the skills at this point to modify the plugin itself, but from what I can tell, adding support for

windowSplashScreenIconBackgroundColor

@bhandaribhumin
Copy link

bhandaribhumin commented Apr 29, 2022

@mlynch @maxcodefaster For capacitor project this is the fix :)

Screenshot 2022-04-29 at 8 05 38 PM

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 30, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants