diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca99adf4bf..75441c75dc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,6 +29,26 @@ jobs: - run: npm run build - run: npm run lint - run: npm test + test-core: + runs-on: ubuntu-latest + timeout-minutes: 30 + defaults: + run: + working-directory: ./core + steps: + - uses: actions/setup-node@v1 + with: + node-version: 14.x + - uses: actions/checkout@v2 + - name: Restore Dependency Cache + uses: actions/cache@v1 + with: + path: ~/.npm + key: ${{ runner.OS }}-dependency-cache-${{ hashFiles('**/package.json') }} + - run: npm install + - run: npm run build + - run: npm run lint + - run: npm test test-ios: runs-on: macos-latest timeout-minutes: 30 diff --git a/core/src/core-plugin-definitions.ts b/core/src/core-plugin-definitions.ts index 1153834606..2089ed009c 100644 --- a/core/src/core-plugin-definitions.ts +++ b/core/src/core-plugin-definitions.ts @@ -198,7 +198,7 @@ export interface AppRestoredResult { */ error?: { message: string; - } + }; } // @@ -1104,7 +1104,7 @@ export interface LocalNotification { /** * Android only: set the color of the notification icon */ - iconColor?: string + iconColor?: string; attachments?: LocalNotificationAttachment[]; actionTypeId?: string; extra?: any; @@ -1127,8 +1127,8 @@ export interface LocalNotification { */ groupSummary?: boolean; /** - * Android only: set the notification channel on which local notification - * will generate. If channel with the given name does not exist then the + * Android only: set the notification channel on which local notification + * will generate. If channel with the given name does not exist then the * notification will not fire. If not provided, it will use the default channel. */ channelId?: string; @@ -1602,7 +1602,7 @@ export interface NotificationChannelList { export interface PushNotificationsPlugin extends Plugin { /** * Register the app to receive push notifications. - * Will trigger registration event with the push token + * Will trigger registration event with the push token * or registrationError if there was some problem. * Doesn't prompt the user for notification permissions, use requestPermission() first. */ diff --git a/core/src/web/clipboard.ts b/core/src/web/clipboard.ts index 1ca15e838e..0d3d38c4ae 100644 --- a/core/src/web/clipboard.ts +++ b/core/src/web/clipboard.ts @@ -35,7 +35,7 @@ export class ClipboardPluginWeb extends WebPlugin implements ClipboardPlugin { const blob = await (await fetch(options.image)).blob(); const clipboardItemInput = new ClipboardItem({[blob.type] : blob}); await navigator.clipboard.write([clipboardItemInput]); - }catch(err) { + } catch (err) { return Promise.reject('Failed to write image'); } } else { diff --git a/core/src/web/local-notifications.ts b/core/src/web/local-notifications.ts index 16b78919d4..83e7369dce 100644 --- a/core/src/web/local-notifications.ts +++ b/core/src/web/local-notifications.ts @@ -23,7 +23,7 @@ export class LocalNotificationsPluginWeb extends WebPlugin implements LocalNotif platforms: ['web'] }); } - + createChannel(channel: NotificationChannel): Promise { throw new Error('Feature not available in the browser. ' + channel.id); } @@ -31,7 +31,7 @@ export class LocalNotificationsPluginWeb extends WebPlugin implements LocalNotif deleteChannel(channel: NotificationChannel): Promise { throw new Error('Feature not available in the browser. ' + channel.id); } - + listChannels(): Promise { throw new Error('Feature not available in the browser'); }