-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add immersive configuration to Splash #2425
Conversation
@jcesarmobile I wanted to ask for your help with this one. I'll attach gif below that shows current functionality, you will notice these 2 issues
Unfortunately my knowledge of android is not enough to figure out why exactly this is happening. As you can see in #2423 there are few more things I am doing maybe its missing here? I tried adding |
No idea, try with windowBackground instead of background |
Same issue, also tried to add I will continue trying ideas out to fix this "jump" effect as they come. |
@jcesarmobile I spent 2h trying to fix this jump today, but came up empty handed. Can this be merged as is, or should we keep looking for solution? Perhaps you could suggest someone I can reach out to that might be able to help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
merging now that the jump was fixed in another PR.
would be good if you could send another PR documenting it on https://github.com/ionic-team/capacitor/blob/master/site/docs-md/apis/splash-screen/index.md
and if you also document splashFullScreen
even better.
Added documentation #2613 |
I still have the same problem. Only the top bar is hidden. I have this in my capacitor.config.json
}` and this is android\app\src\main\res\values\styles.xml ` <style name="AppTheme.NoActionBarLaunch" parent="AppTheme.NoActionBar">
` |
I'm also experiencing the same issue with the jump... |
For Capacitor, I did like this, and it works fine!
|
I had a different problem. In my case, the gray bar was displayed in place of the status bar. <item name="android:background">@android:color/white</item> or if you want to have white background only during launch: <item name="android:windowBackground">@android:color/white</item>
<item name="android:fitsSystemWindows">true</item> |
This adds additional flag to capacitor config called
splashImmersive
that allows to hide not only status bar (achieved by using already existingsplashFullScreen
flag) but also software navigation bar. More info available here https://developer.android.com/training/system-ui/immersive#immersiveThis particular configuration uses "Sticky Immersive" approach https://developer.android.com/training/system-ui/immersive#sticky-immersive
closes #2423