Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Site: Bad Link #2535

Closed
alexsasharegan opened this issue Mar 6, 2020 · 2 comments · Fixed by #2542
Closed

Documentation Site: Bad Link #2535

alexsasharegan opened this issue Mar 6, 2020 · 2 comments · Fixed by #2542

Comments

@alexsasharegan
Copy link

Bug Report

Visiting the Push Notification doc page, there is a cross link to the Local Notifications page. Currently, the link is broken. The cause of the break is both a bad path and a case sensitive issue. Note the difference:

  • Linked Page: https://capacitor.ionicframework.com/docs/local-notifications
  • Actual Page: https://capacitor.ionicframework.com/docs/apis/local-Notifications/

I see that the markdown docs use the lower-cased directory names, but I imagine something in the deploy chain is case-insensitive. Also, it's a bit confusing how the directory of md pages resolves the built html and their paths. The directory walk up in the source file appears to be unnecessary: site/docs-md/apis/push-notifications/index.md.

@jcesarmobile
Copy link
Member

I've fixed the local-notifications vs local-Notifications thing.

The other problem is a known issue on our relative urls.

If you go to Push Notifications page, it loads https://capacitor.ionicframework.com/docs/apis/push-notifications url and the link is broken, but if while being there you refresh, it becomes https://capacitor.ionicframework.com/docs/apis/push-notifications/ and then the link works.

We should probably make the plugin urls to always finish with /

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants