Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): return error if Cancel is selected from Camera.getPhoto() prompt #2550

Merged
merged 2 commits into from
Mar 18, 2020
Merged

fix(ios): return error if Cancel is selected from Camera.getPhoto() prompt #2550

merged 2 commits into from
Mar 18, 2020

Conversation

christhompson05
Copy link
Contributor

@christhompson05 christhompson05 commented Mar 10, 2020 •
edited
Loading

First time contributor.

Noticed that nothing was being returned from Camera.getPhoto() on iOS if source is CameraSource.Prompt and 'Cancel' is selected.

fixes #2196

@christhompson05 christhompson05 changed the title fix(ios) error not being shown when 'Cancel' is selected from Camera plugin prompt fix(ios) nothing is returned when 'Cancel' is selected from Camera plugin prompt Mar 10, 2020
@christhompson05 christhompson05 changed the title fix(ios) nothing is returned when 'Cancel' is selected from Camera plugin prompt fix(ios): nothing is returned when 'Cancel' is selected from Camera plugin prompt Mar 10, 2020
jcesarmobile
jcesarmobile requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

ios/Capacitor/Capacitor/Plugins/Camera.swift Outdated Show resolved Hide resolved
@jcesarmobile jcesarmobile changed the title fix(ios): nothing is returned when 'Cancel' is selected from Camera plugin prompt fix(ios): return error if Cancel is selected from Camera.getPhoto() prompt Mar 18, 2020
jcesarmobile
jcesarmobile approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@jcesarmobile jcesarmobile merged commit a015f8f into ionic-team:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Camera API getPhoto does not indicate if user cancelled the initial dialog
2 participants
@christhompson05 @jcesarmobile