Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Splash): document splashFullScreen and splashImmersive config options #2613

Merged
merged 1 commit into from
Mar 23, 2020
Merged

docs(Splash): document splashFullScreen and splashImmersive config options #2613

merged 1 commit into from
Mar 23, 2020

Conversation

xzilja
Copy link
Contributor

@xzilja xzilja commented Mar 21, 2020 •
edited
Loading

@xzilja xzilja mentioned this pull request Mar 21, 2020
Merged
@xzilja xzilja changed the title Add documentation for splashFullScreen and splashImmersive docs: splashFullScreen and splashImmersive Mar 21, 2020
jcesarmobile
jcesarmobile approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile changed the title docs: splashFullScreen and splashImmersive docs(Splash): document splashFullScreen and splashImmersive Mar 23, 2020
@jcesarmobile jcesarmobile changed the title docs(Splash): document splashFullScreen and splashImmersive docs(Splash): document splashFullScreen and splashImmersive config options Mar 23, 2020
@jcesarmobile jcesarmobile merged commit c381202 into ionic-team:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzilja @jcesarmobile @iljadaderko