Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Add lights and lightColor to PushNotificationChannel #2618

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

jcesarmobile
Copy link
Member

Add lights and lightColor properties to PushNotificationChannel, so can be used on createChannel and returned by listChannels.

This allows to enable led light for push notifications and configure it's color (if the device supports it)

Also make description and sound optional since the native code had default values for when they are not provided.

closes #2547

@jcesarmobile jcesarmobile merged commit 4c0170c into ionic-team:master Mar 23, 2020
@jcesarmobile jcesarmobile deleted the push-lights branch March 23, 2020 15:39
@dibyendusaha
Copy link
Contributor

is it possible to add Large icon configuration as well for both Push Notification and Local Notification?

@fromage9747
Copy link

whilst you can turn the lights on, the colour cannot be configured. Tested on a note8 which has the ability to change the colour of the lights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: No led blink on receive of fcm push notification
3 participants