Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add presentVC and dismissVC methods to bridge #2678

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Apr 2, 2020

Add utility presentVC and dismissVC methods in the bridge for plugins to use.
They use a temporary window and temporary view controller, so the webview javascript execution is not frozen when the view controller is presented.

Changed the Browser implementation to use this two new methods so it fixes #2660

@jcesarmobile jcesarmobile merged commit a6c91da into ionic-team:master Apr 2, 2020
@jcesarmobile jcesarmobile deleted the tmp-window branch April 2, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser.close() does not close the open browser ios IOS
2 participants