Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cordova): Add cordova-support-google-services to incompatible list #2912

Merged

Conversation

jcesarmobile
Copy link
Member

the plugin just apply plugin com.google.gms.google-services, but Capacitor already does it, so it's not needed and makes the apply of Capacitor to fail and show the google-services.json not found, google-services plugin not applied. Push Notifications won't work that might confuse users, so make the CLI skip it.

@jcesarmobile jcesarmobile merged commit 58d0768 into ionic-team:master May 13, 2020
@jcesarmobile jcesarmobile deleted the incompatible-goole-services branch May 13, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant