Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ce-plugins) add @byrds/capacitor-contacts plugin #2939

Merged
merged 2 commits into from
May 18, 2020

Conversation

Idrimi
Copy link
Contributor

@Idrimi Idrimi commented May 16, 2020

Hi,

finally had the time to add Android Support to my Capacitor-Contacts Plugin.
Updated the docs as well. You can find a link to a working demo as well.

As Contacts fetching is a commonly used native function (and i guess there will be more people creating Contact Plugins) I allowed myself to create a section.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, since there is only one, can you put it in the misc section? if in the future we get more we can reconsider

other than that, it looks good

@Idrimi
Copy link
Contributor Author

Idrimi commented May 18, 2020

Hi @jcesarmobile,

I would prefer having it in another section. As those in the "misc" section are rather small and/or visual plugins. Bluetooth, Sensors, Date/Calendar or Deep Links have their own section as well.
Storage Section would make sense as well and I would be fine with that too. What do you think?

@jcesarmobile
Copy link
Member

I disagree, I already told you to put it in the Misc section in the first PR you sent

@Idrimi
Copy link
Contributor Author

Idrimi commented May 18, 2020

Ok, cool. Then we will put it in the "misc" section. 😜

@jcesarmobile jcesarmobile changed the title added Capacitor Contacts Plugin community plugins.md docs(ce-plugins) add @byrds/capacitor-contacts plugin May 18, 2020
@jcesarmobile jcesarmobile merged commit 56d4159 into ionic-team:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants