feat(Permissions): allow microphone check #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Jun 8, 2020
There was a problem hiding this comment.
changes look good, thanks!
but can you remove commit f5fe0a0? the docs are generated on deploy, so don't commit them
jcesarmobile
changed the title
This reverts commit f5fe0a0.
|
Ok it's good. Are you planning the Microphone in capacitor ? (Recording, access request) ? |
jcesarmobile
approved these changes
Jun 8, 2020
|
not planning on adding a microphone plugin for now, but a few things can trigger the microphone permission at the moment, like some cordova plugins, input file with capture attribute, getUserMedia on Android/browser, etc. so having the microphone check might be helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkMicrophone in permission plugin