Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): Make androidx.exifinterface version configurable #3236

Merged
merged 2 commits into from
Jul 10, 2020
Merged

chore(android): Make androidx.exifinterface version configurable #3236

merged 2 commits into from
Jul 10, 2020

Conversation

jcesarmobile
Copy link
Member

add androidxExifInterfaceVersion variable into the variables.gradle file with value set to 1.2.0
use the variable in capacitor's build.gradle file but also default to 1.2.0 if not set

smpeters
smpeters approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@smpeters smpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imhoffd imhoffd merged commit 3c64162 into ionic-team:master Jul 10, 2020
@imhoffd imhoffd deleted the exif-interface-variable branch July 10, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smpeters smpeters smpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcesarmobile @smpeters @imhoffd