bug: npx cap sync does not return a non zero status on update failure

[dan-overton]

Bug Report

Capacitor Version

Latest Dependencies:

@capacitor/cli: 2.4.1
@capacitor/core: 2.4.1
@capacitor/android: 2.4.1
@capacitor/electron: 2.4.1
@capacitor/ios: 2.4.1

Installed Dependencies:

@capacitor/cli 2.4.1
@capacitor/android 2.4.1
@capacitor/core 2.4.1
@capacitor/ios 2.4.1
@capacitor/electron not installed

[success] Android looking great! 👌
Found 0 Capacitor plugins for ios:
[success] iOS looking great! 👌

Platform(s)

ios, android

Current Behavior

When running npx cap sync <platform>, if the update fails the command does not exit with a non zero status.
This means that our CI system thought the sync had completed successfully when in fact it had failed.
The subsequent iOS build failed as relevant cocoapods had not been installed.

Rerunning the build worked as the error was transient.

Relevant logging:

Expected Behavior

The command should exit with a non zero status, so we can tell if the command errored in CI.

Code Reproduction

n/a

Other Technical Details

The exception that would show us the error is caught and not re-thrown at

capacitor/cli/src/tasks/update.ts

Line 89 in d7bf775

logger.error(`Error running update:\n` + (e.stack ?? e));

(I think!)

[imhoffd]

I believe the current behavior is for when the command is run as npx cap sync and it syncs multiple platforms, but I think it makes more sense to fail early if any error is encountered.

Thanks for the report!

[dan-overton]

No problem! Many thanks for taking a look at this so quickly.

[jcesarmobile]

this was fixed on 2.4.2

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.