feat(cli): create TS configuration files in init
#3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
reviewed
Jan 7, 2021
jcesarmobile
requested changes
Jan 7, 2021
There was a problem hiding this comment.
The generated .ts file in an existing angular app makes vs code to complain with
Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
so probably not a good idea to default to the .ts file if it can cause problems or the .ts file should be changed to support angular apps.
Agreed, see #4031 |
|
#4031 is now merged. I think we should document |
|
not just document it, this PR should also use it on the initial .ts file creation |
jcesarmobile
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.