Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): configurable iOS build scheme #4073

Merged
merged 2 commits into from
Jan 19, 2021
Merged

feat(cli): configurable iOS build scheme #4073

merged 2 commits into from
Jan 19, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Jan 16, 2021

This allows custom scheme names to be used when running npx cap run.

@imhoffd imhoffd added this to the 3.0.0-rc milestone Jan 16, 2021
@imhoffd imhoffd linked an issue Jan 16, 2021 that may be closed by this pull request
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works fine

but wouldn't it better to make it a param on the run command?
i.e: capacitor run ios --scheme="MyScheme"

Also the scheme name might be a little confusing since we have iosScheme on server object that configures the scheme of the url used to load the app and also the app url scheme for opening the app from another app.

@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 19, 2021

but wouldn't it better to make it a param on the run command?

Maybe, but later on we may want to use the build scheme to derive more information about the iOS project for sync, etc. By using xcodebuild -showBuildSettings with the configured scheme, we can get the folder structure of the project and know exactly where everything is, which means developers can rename folders. I also think it will be useful if we ever add the npx cap build command.

scheme name might be a little confusing since we have iosScheme

I would rather deprecate iosScheme in favor of server.ios.httpScheme (and server.android.httpScheme for Android) to clear up any potential confusion. What do you think?

@jcesarmobile
Copy link
Member

Then httpScheme name is confusing because you can't really use http value.

Anyway, I approved the changes, just sharing my concerns.

@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 19, 2021

Wow, my brain said urlScheme but I wrote httpScheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration option for iOS target(s)
2 participants