Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): get PermissionState enum by state value #4100

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

carlpoole
Copy link
Member

@carlpoole carlpoole commented Jan 20, 2021

Matching the lower-case and kebab case state values to the enum names was not working as intended

The enum method valueOf must match the enum name exactly.
Eg. "denied" did not match to DENIED

@carlpoole carlpoole merged commit 194ae86 into main Jan 21, 2021
@carlpoole carlpoole deleted the perm-enum branch January 21, 2021 18:06
@imhoffd imhoffd added this to the 3.0.0-beta.2 milestone Jan 29, 2021
@leo6104
Copy link

leo6104 commented Feb 1, 2021

I'm waiting for this commit to be released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants