Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): do not error if webDir is missing when adding platforms #4215

Merged
merged 6 commits into from
Feb 18, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Feb 16, 2021

Automatically running sync during add can cause some undesired behavior when first setting up an app (see ionic-team/ionic-cli#4510).

Instead of recommending to people that they "open their IDE" after add, we now just link to the Developer Workflow docs. We don't know what state their project is in when they add a platform.

@imhoffd imhoffd added this to the 3.0.0-rc milestone Feb 16, 2021
@imhoffd imhoffd changed the title fix(cli): do not run sync during add fix(cli): do not error if webDir is missing when adding platforms Feb 17, 2021
@imhoffd imhoffd merged commit 4583add into main Feb 18, 2021
@imhoffd imhoffd deleted the no-sync-during-copy branch February 18, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants