-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): Obj-C convenience accessors on CAPPluginCall #4309
Conversation
…e implementation on the call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the bridged types have a getBool like the swift plugin call has?
Having to use NSNumber every time you want a boolean might make users use the deprecated getBool from CAPPlugin class instead as it's easier to get despite it's deprecated.
@jcesarmobile |
If they are using a getBool and they are told that that getBool is deprecated and should use the ones from pluginCall, but there is no getBool there it's not trivial to know that they can use getNumber and cast to bool |
That's a fair point. It probably makes sense to ease the migration from the deprecated methods. |
This branch revisits the Obj-C versions of the CAPPluginCall convenience accessors, deprecates the redundant methods on CAPPlugin, adds test coverage, and fixes a bug with dates.
getNumber
method for NSNumber values.CAPPlugin
accessors to use the call's implementation.CAPPlugin
accessors as deprecated.getDate
.