-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): Include native-bridge.js as a resource in both Cocoapods and direct build #4505
Conversation
If we are going to have the bundle file, then we should use it instead of having two (this one and the generated by CocoaPods) |
I'm not sure I understand. This change has Xcode generate a |
The other option is that we just use the Cocoapods I don't have a strong opinion either way, I just want to ensure that the final product is the same structure regardless of how it gets built (from the capacitor .xcworkspace or via Cocoapods) |
I tried that and wasn’t able to read the file, but if you can make it work I’m ok with it |
Updated. This uses the podspec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine and reduces the code, nice!
This branch updates the podspec and direct build process of the Capacitor.framework to ensure that they build functionally identical frameworks. Specifically, the
native-bridge.js
file is added as a resource for the framework in both scenarios. It also adds a test case to verify that the injection method can locate the javascript file as expected.