fix(android): Set WEBVIEW_SERVER_URL before injecting native-bridge #4748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs
Capacitor.convertFileSrc
should return an URL starting withhttp://localhost
on android, but instead this part is missing and something like/_capacitor_file_/path/to/device/file
is returned.convertFileSrc
gets the host part fromwebviewServerUrl
, which is set when native-bridge is loaded:capacitor/core/native-bridge.ts
Lines 356 to 357 in ca4e3b6
Because of the injection order,
win.WEBVIEW_SERVER_URL
has not been set yet when this line is executed. This PR fixes that by injecting the part that setsWEBVIEW_SERVER_URL
before native-bridge.