Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): being able to register multiple plugins from same package #5098

Merged
merged 3 commits into from
Oct 18, 2021
Merged

fix(cli): being able to register multiple plugins from same package #5098

merged 3 commits into from
Oct 18, 2021

Conversation

sosoba
Copy link
Contributor

@sosoba sosoba commented Oct 5, 2021 •
edited by jcesarmobile
Loading

Reset multiline regexp for multiple ussage.

Currently update cannot detect multiple plugins.

closes #4855

@sosoba
Update update.ts
ae22e97 
Reset multiline regexp for multiple ussage
@sosoba sosoba mentioned this pull request Oct 5, 2021
Closed
@jcesarmobile jcesarmobile changed the title Reset regexp fix(cli): being able to register multiple plugins from same package Oct 18, 2021
jcesarmobile
jcesarmobile approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit 25e770c into ionic-team:main Oct 18, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx cap sync android returns [error] Package could not be parsed from Android plugin.
2 participants
@sosoba @jcesarmobile