-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add support for 'pod install' in VM based environments #5144
Conversation
The OS check as there more because of xcodebuild than because of pod install. I don’t think you can run xcodebuild on Linux. I have not tried the change on a vm, but it will probably fail because of that. |
I added a function to check if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added three comments.
We in fact have an isInstalled
function already, so should use that instead of which (it uses which internally) and instead of having two functions for checking.
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
Finally made the changes to this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed some unused imports, the platform check since the update file is the iOS file, so the platform is always iOS, and also moved the pod check right before running pod install since users might still want the Podfile to be updated despite they don't have CocoaPods installed in case they run update on windows/linux but build on mac without running update there
Fixes #5069
Directly check for
pod
executable rather than just failing on not Mac OS. Allows for use of capacitor if running the cli from within a vm container like docker or vagrant.