feat: Add CapWebView #5715
feat: Add CapWebView #5715
Conversation
…5487) fix(ios): Add `getValue(_:)` method to JSValueContainer. This intends to replace `getAny(_:)`, since we are not ever going to be returning a type that does not conform to `JSValue`. fix(ios): Update CAPWebView to use autolayout to pin the child webview to it's leading, trailing, top, and bottom constraints. This was causing issues with when CAPWebView is nested deep within a view heirarchy. Refactor to make `webView` and `capacitorBridge` to no longer be optionals through the use of lazy vars.
jcesarmobile
requested review from
giralte-ionic,
IT-MikeS,
ItsChaceD,
Steven0351 and
theproducer
|
One thing here that slipped my attention was the merge of main back into |
|
The idea of merging portals-dev into main is to get rid of portals-dev branch and with that the required extra step on publishing. native-publish branch will always exist for publishing, we will need to update it to use main instead of portals-dev branch as portals-dev branch would be deleted after the merge of this PR. If we are going to keep publishing v3 versions, we will need a new native-publish-v3 branch that points to the 3.x branch and cherry pick this CapWebView changes into 3.x branch too. |
Co-authored-by: Ely Lucas <[email protected]> Co-authored-by: Steven Sherry <[email protected]> Co-authored-by: Steven Sherry <[email protected]>
Co-authored-by: Ely Lucas <[email protected]> Co-authored-by: Steven Sherry <[email protected]> Co-authored-by: Steven Sherry <[email protected]>
No description provided.