fix(android): get application/x-www-form-urlencoded as string

[jcesarmobile]

As far as I understand, when using application/x-www-form-urlencoded you send a string, so that's why the body.toJSObject() is crashing, because it's a string, not a JSObject.

The PR removes the whole application/x-www-form-urlencoded else and goes directly to the final else where it read the body as string.

If you think there might be bases where the application/x-www-form-urlencoded could be getting a JSObject, let me know and I'll change the code to catch the JSON exception and fallback to string in that case.

closes #5996

[theproducer]

Looks good. Tested this with one of the supplied reproductions and it worked.

As far as I know, I don't think you have to worry about JSObjects from a x-www-form-urlencoded response. if that does happen, it should be on the caller to take the body response and parse as JSON.

[IT-MikeS]

x-www-form-urlencoded requests should always be sent with URL Query String formatted bodies. Users can accomplish this via a couple options:

• URLSearchParams in JS

• A custom mapping function that will convert your JS Object into query params:

const bodyRequest = Object.keys(myJSObject).map(key => `${encodeURIComponent(key)}=${encodeURIComponent(myJSObject[key])}`).join('&');

In this case the Cap HTTP Plugin was accepting users sending JSON strings then auto converting them for users.

[dnietodev]

Hello, when can we expect to have this fix with the next release of capacitor?

Thanks!

[jcesarmobile]

This was released in 4.6.2

[dv-alan]

Hi, any reason why this was introduced? I'm using this in conjunction with an .NET Core Web API and can confirm that the above is resulting in malformed requests. Comparing this to the old capacitor-community http plugin, this amendment leaves a lot unhandled especially when it comes to multi-part/form-data. Applying .ToString() on any http request params other than application/json will not render anything useful. Other forms of encoding are a must for this to work in a more complex scenario.

Kindly refer to this snippet here.

Thanks in advance.