feat(android): add ability to create config from a custom file path #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giralte-ionic
approved these changes
Feb 1, 2023
IT-MikeS
requested changes
Feb 6, 2023
android/capacitor/src/main/java/com/getcapacitor/CapConfig.java
Outdated
Show resolved
Hide resolved
carlpoole
commented
Feb 6, 2023
android/capacitor/src/main/java/com/getcapacitor/CapConfig.java
Outdated
Show resolved
Hide resolved
IT-MikeS
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create configs from a provided file path. It will be used by Portals to allow config files to be contained within specific Portal subdirs in assets and also to allow them to be contained within live update files on disk.
This PR also fixes a bug that was found where CapacitorWebView may not read the correct config that was provided to Capacitor when used with Portals.