fix(android): solve and/or silence lint errors #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
giralte-ionic,
IT-MikeS,
ItsChaceD,
markemer and
theproducer
IT-MikeS
approved these changes
Mar 2, 2023
markemer
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting SDK 33, multiple
DiscouragedApierrors appear inBridgeActivity.javaandAssetUtil.javaclasses because of the usage of reflection for getting resources from the name.BridgeActivity.javaI've usedR.style.AppTheme_NoActionBarinstead of the name, there was already a line like that for the activity theme, so removed the string one and replace the string with theR.style.AppTheme_NoActionBaron the app theme line. Not sure if it was a mistake to have them duplicated, but doesn't seem to break anything with the change.For
AssetUtil.javait can't be fixed because we allow plugins to get resources dynamically from the javascript name the users provide, so I've just silenced the warnings.We could probably remove some of the methods that generate the warnings since looks like some of them are not being used, but not all of them.